Feature/runtime fonts #963
Open
+148
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a8b53d.
remove blank lines
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion Reference
https://discord.com/channels/531175899588984842/536970543736291346/1233539611368751185
Is this a breaking change?
No.
I outcommented the ranges that crash for users that do not have a specific .NET Runtime installed and run BlishHUD only with the windows shipped one.
I let @teebee-git (Discord: tommyball) test each range one by one.
As a final test I also had him install .NET Runtime 8 and test a version with all the ranges active which worked.
There are now two options: Either we recommend to people to install the latest .NET Runtime somewhere visible so we are able to use the whole charset of gw2 or stick with the ranges that work even without it.