Fixed recipe models #199
Merged
Fixed recipe models #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed recipe models. Added AllianceCraftedItem and HordeCraftedItem properties for recipes that produce faction-specific items. Added a ModifiedCraftingSlots property for recipes that allow modified crafting. Added a supporting ModifiedCraftingSlot model type. Updated the CraftedQuantity model type to add a Value property and made the existing Minimum and Maximum properties nullable since they are not always present. Added new tests to ensure these cases are tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed recipe models. Added
AllianceCraftedItemandHordeCraftedItemproperties for recipes that produce faction-specific items. Added aModifiedCraftingSlotsproperty for recipes that allow modified crafting. Added a supportingModifiedCraftingSlotmodel type. Updated theCraftedQuantitymodel type to add aValueproperty and made the existingMinimumandMaximumproperties nullable since they are not always present. Added new tests to ensure these cases are tested.Resolves #197.