fix: updated oauth hosts according latest battlenet api changes #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey, any updates on this? |
bonesoul
changed the title
danjagnow
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Looks good! This matches the docs at https://develop.battle.net/documentation/guides/using-oauth, as you indicated.
My apologies for the delay. Thanks for submitting this fix! |
|
all good! thanks for the PR in. |
danjagnow
added a commit
that referenced
this pull request
Apr 29, 2023
Added some fixes to get the unit and integration tests working again. Updated the ClientFactory for the unit tests to expect https://oauth.battle.net/oauth/token instead of https://us.battle.net/oauth/token to adapt to the changes in #212. Also updated the PlayableClass and PlayableRace model classes to add new properties that indicate which classes and races can be combined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #211.