Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new fields for Keystone Leaderboard. Fixing tests while i was at it. #218

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

andyjmorgan
Copy link
Contributor

@andyjmorgan andyjmorgan commented Feb 18, 2024

Added Keystone rating (score + color) for leaderboard entries.
Pvp talent moved to 40 as 11 no longer exists.
Resolved missing 10.2.5 properties.

@andyjmorgan
Copy link
Contributor Author

@danjagnow requesting a review at your next convenience :)

…, PlayableSpecialization, Region and updating the TalentAPITests to request a valid talent. Updated the Test Responses
Copy link
Collaborator

@danjagnow danjagnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the updates and fixes.

@danjagnow danjagnow merged commit 89e21a5 into blizzard-net:main Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants