Prepare test suite for for v2.4 of the GraphQL gem. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before v2.4 of the GraphQL gem, `GraphQL::Schema#types` returned _all_ types defined by the SDL string. Beginning in v2.4, orphaned types (that is, types not reachable from the root `Query` type) are no longer included. We have a number of unit tests that define orphaned types since we don't want or need a full schema for such a test. To avoid issues as part of upgrading to v2.4, we need to ensure that our tests don't depend on orphaned types that are unavailable in v2.4 and later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before v2.4 of the GraphQL gem,
GraphQL::Schema#typesreturned all types defined by the SDL string. Beginning in v2.4, orphaned types (that is, types not reachable from the rootQuerytype) are no longer included. We have a number of unit tests that define orphaned types since we don't want or need a full schema for such a test.To avoid issues as part of upgrading to v2.4, we need to ensure that our tests don't depend on orphaned types that are unavailable in v2.4 and later.