Refactor: simplify and optimize ElasticGraph::GraphQL::Schema.
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoid calling `::GraphQL::Schema#types` repeatedly. As reported in rmosolgo/graphql-ruby#5154, accessing `#types` repeatedly can be quite slow (at least on 2.4.0 - 2.4.2). While it's been optimized in 2.4.3, there's no need to access it more than once. Previously, we accessed it in `#lookup_type_by_name`; instead we can just use the type objects as we iterate over `::GraphQL::Schema#types` a single time. - Remove unused `#defined_types` method. - Inline the old `#lookup_type_by_name` logic into `#type_named`.
myronmarston
force-pushed
the
myron/upgrade-graphql-2.4/schema-prep1
branch
from
c748940
to
571c2fd
Compare
myronmarston
changed the title
ElasticGraph::GraphQL::Schema.ElasticGraph::GraphQL::Schema.
myronmarston
added a commit
that referenced
this pull request
Nov 12, 2024
I removed it in #31 because ElasticGraph didn't rely on it or need it. However, I discovered that Block has an internal extension library that relies on it, and it's a generally useful API to offer for extension libraries. This restores it (but with a simplified implementation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
::GraphQL::Schema#typesrepeatedly. As reported in Performance regression in 2.4:Schema#typesis much slower to access repeatedly rmosolgo/graphql-ruby#5154, accessing#typesrepeatedly can be quite slow (at least on 2.4.0 - 2.4.2). While it's been optimized in 2.4.3, there's no need to access it more than once. Previously, we accessed it in#lookup_type_by_name; instead we can just use the type objects as we iterate over::GraphQL::Schema#typesa single time.#defined_typesmethod.#lookup_type_by_namelogic into#type_named.