Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions/setup-node from v3 to v4. #4

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

myronmarston
Copy link
Collaborator

This should address a warning our builds have been getting1:

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info:
https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Footnotes

  1. https://github.com/block/elasticgraph/actions/runs/11565680928

This should address a warning our builds have been getting[^1]:

> The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info:
> https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

[^1]: https://github.com/block/elasticgraph/actions/runs/11565680928
Copy link
Collaborator

@BrianSigafoos-SQ BrianSigafoos-SQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myronmarston myronmarston merged commit 0ef96bb into main Oct 29, 2024
9 checks passed
@myronmarston myronmarston deleted the myron/address-actions-warning branch October 29, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants