Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding in ability to provide per repo hints #32

Merged
merged 2 commits into from
Sep 4, 2024
Merged

adding in ability to provide per repo hints #32

merged 2 commits into from
Sep 4, 2024

Conversation

michaelneale
Copy link
Collaborator

After trying a few approaches, this simple one still seems potentially relevant (you can put specific instructions for goose in a repo).

Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! - i think the implementation is correct but the tests are not currently checking it

tests/toolkit/test_developer.py Outdated Show resolved Hide resolved
tests/toolkit/test_developer.py Outdated Show resolved Hide resolved
tests/toolkit/test_developer.py Outdated Show resolved Hide resolved
tests/toolkit/test_developer.py Outdated Show resolved Hide resolved
tests/toolkit/test_developer.py Outdated Show resolved Hide resolved
@michaelneale
Copy link
Collaborator Author

@baxen yeah - this was nonsense test code, removed it for now so we can merge it in.

@michaelneale michaelneale merged commit 13db515 into main Sep 4, 2024
1 check passed
@michaelneale michaelneale deleted the hint branch September 4, 2024 06:18
lifeizhou-ap added a commit that referenced this pull request Sep 4, 2024
…nctions

* main:
  adding in ability to provide per repo hints (#32)
lukealvoeiro added a commit that referenced this pull request Sep 4, 2024
…l-commit-title-pr

* origin/main:
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
  chore: gitignore generated lockfile (#15)
  add prompts (#11)
  conditionally publish only when config changes (#9)
lukealvoeiro pushed a commit that referenced this pull request Sep 9, 2024
* adding in ability to provide per repo hints

* tidy up test
lukealvoeiro added a commit that referenced this pull request Sep 9, 2024
* main:
  fix: typo in exchange method `rewind` (#54)
  fix: remove unsafe pop of messages (#47)
  chore: Update LICENSE (#53)
  chore(docs): update is_dangerous_command method description (#48)
  refactor: improve safety rails speed and prompt (#45)
  feat: make goosehints jinja templated (#43)
  ci: enforce PR title follows conventional commit (#14)
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
Kvadratni added a commit to Kvadratni/goose that referenced this pull request Sep 23, 2024
* origin/main:
  chore: release 0.9.0 (block#58)
  fix: goose should track files it reads and not overwrite changes (block#46)
  docs: Small dev notes for using exchange from source (block#50)
  fix: typo in exchange method `rewind` (block#54)
  fix: remove unsafe pop of messages (block#47)
  chore: Update LICENSE (block#53)
  chore(docs): update is_dangerous_command method description (block#48)
  refactor: improve safety rails speed and prompt (block#45)
  feat: make goosehints jinja templated (block#43)
  ci: enforce PR title follows conventional commit (block#14)
  feat: show available toolkits (block#37)
  adding in ability to provide per repo hints (block#32)
  Apply ruff and add to CI (block#40)
  added some regex based checks for dangerous commands (block#38)
  chore: Update publish github workflow to check package versions before publishing (block#19)

# Conflicts:
#	src/goose/toolkit/developer.py
#	src/goose/utils/check_shell_command.py
#	tests/utils/test_check_shell_command.py
lily-de pushed a commit that referenced this pull request Oct 7, 2024
* adding in ability to provide per repo hints

* tidy up test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants