fix(dex): remove hardcoded bcdc fee percentage

blockchain · May 1, 2024 · fe341b1 · fe341b1
1 parent e0682c1
commit fe341b1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/...lockchain-wallet-v4-frontend/src/scenes/Dex/Swap/components/QuoteDetails/QuoteDetails.tsx b/...lockchain-wallet-v4-frontend/src/scenes/Dex/Swap/components/QuoteDetails/QuoteDetails.tsx
@@ -160,7 +160,9 @@ export const QuoteDetails = ({
                     coin: props.swapQuote.quote.sellAmount.symbol,
                     value: Exchange.convertCoinToCoin({
                       coin: props.swapQuote.quote.sellAmount.symbol,
-                      value: (props.swapQuote.quote.sellAmount.amount / 100) * 0.9
+                      value:
+                        (props.swapQuote.quote.sellAmount.amount / 100) *
+                        props.swapQuote.quote.bcdcFeePercentage
                     })
                   })}
                 </FiatDisplay>

diff --git a/packages/blockchain-wallet-v4/src/network/api/dex/schemas.ts b/packages/blockchain-wallet-v4/src/network/api/dex/schemas.ts
@@ -72,6 +72,7 @@ const DexBcdcFeeSchema: z.ZodSchema<DexBcdcFee, z.ZodTypeDef, unknown> = z.objec
 
 const DexQuoteSchema: z.ZodSchema<DexQuote, z.ZodTypeDef, unknown> = z.object({
   bcdcFee: DexBcdcFeeSchema,
+  bcdcFeePercentage: stringToPositiveFloat,
   buyAmount: DexBuyAmountSchema,
   buyTokenFee: stringToPositiveFloat,
   price: stringToPositiveFloat,

diff --git a/packages/blockchain-wallet-v4/src/network/api/dex/types.ts b/packages/blockchain-wallet-v4/src/network/api/dex/types.ts
@@ -51,6 +51,7 @@ export type DexBcdcFee = {
 
 export type DexQuote = {
   bcdcFee: DexBcdcFee
+  bcdcFeePercentage: number
   buyAmount: DexBuyAmount
   buyTokenFee: number
   price: number