Merge pull request #247 from blockful-io/develop

fix: add .env vars to "release" github action
blockful-io · Mar 19, 2024 · a08692f · a08692f
2 parents a936049 + 0d996e9
commit a08692f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -29,6 +29,12 @@ jobs:
       - run: pnpm audit signatures
       - name: Release
         env:
+          NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_WALLET_CONNECT_PROJECT_ID }}
+          NEXT_PUBLIC_ALCHEMY_ETHEREUM_HTTP: ${{ secrets.NEXT_PUBLIC_ALCHEMY_ETHEREUM_HTTP }}
+          NEXT_PUBLIC_ALCHEMY_ETHEREUM_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_ETHEREUM_KEY }}
+          NEXT_PUBLIC_ALCHEMY_SEPOLIA_HTTP: ${{ secrets.NEXT_PUBLIC_ALCHEMY_SEPOLIA_HTTP }}
+          NEXT_PUBLIC_ALCHEMY_SEPOLIA_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_SEPOLIA_KEY }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          JWT_SECRET: ${{ secrets.JWT_SECRET }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: npx semantic-release
diff --git a/lib/client/constants.ts b/lib/client/constants.ts
@@ -154,9 +154,7 @@ export const getCurrentNetworkHttpUrl = (chainId: number) => {
   const httpUrl = getRpcHttpUrlForNetwork.get(chainId);
 
   if (!httpUrl) {
-    if (process.env.NODE_ENV === "production")
-      throw new Error(`No RPC URL was defined for chain ID: ${chainId}`);
-    else console.error(`No RPC URL was defined for chain ID: ${chainId}`);
+    throw new Error(`No RPC URL was defined for chain ID: ${chainId}`);
   }
 
   return httpUrl;