Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS avatar don't reset after disconnecting the wallet #223

Merged

Conversation

eduramme
Copy link
Contributor

closes #210

Copy link

vercel bot commented Mar 17, 2024

@eduramme is attempting to deploy a commit to the Shared Blockful's projects Team on Vercel.

A member of the Team first needs to authorize it.

@eduramme eduramme linked an issue Mar 17, 2024 that may be closed by this pull request
1 task
Copy link
Member

@heronlancellot heronlancellot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey yo @eduramme ! When we:
1 - search user
2 - select tokens
3 - disconnect we are getting the popup from SwapContext

      toast.error(
        "Your input is not a valid address and neither some registered ENS domain",
      );

For this use case when the user disconnect maybe we can display a toast for it..
Like 'Disconnected from the dApp' or just don't display anything 😄 but removing the toast in that use-case 🤔
Let's check the #224 if we handle this in that issue ? 🤔

Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you @eduramme !!

@0xneves 0xneves merged commit 88f1e1c into blockful-io:develop Mar 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

fix: ENS avatar don't reset after disconnecting the wallet
4 participants