Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: connectWallet with autoSelect and disableModal doesn't works if call it more than one time #1032

Closed
applicature-dlitvinov opened this issue May 31, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@applicature-dlitvinov
Copy link
Contributor

Current Behavior

For example, developers don't want to use a native modal for the connection wallets.
For example needs to connect only with WalletConnect after clicking on the Connect button, without any modals.
You will use the following code after the Connect button is clicked:

onboard.connectWallet({
  autoSelect: {
    label: 'WalletConnect',
    disableModals: true
  }
})

When the user clicks on the Connect button the first time the WalletConnect modal with QR code opens, so it works as expected.
If the user clicks on the close button and clicks on the Connect button again, nothing happens.

Look at the video:
https://user-images.githubusercontent.com/101503007/171252895-405d42fb-c529-4f81-8066-43bcb2b66830.mov

Expected Behavior

When the user clicks on the Connect button the second time if the previous time connection was canceled, the WalletConnect modal with QR code should be opened.

Steps To Reproduce

No response

Onboard Version

2.2.9

Node Version

16.15.0

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Anything else?

No response

@applicature-dlitvinov
Copy link
Contributor Author

fixed in #1033

applicature-dlitvinov added a commit to applicature-dlitvinov/web3-onboard that referenced this issue Jun 2, 2022
@Adamj1232
Copy link
Member

@applicature-dlitvinov thank you for this submission! I reviewed today, left PR comments

applicature-dlitvinov added a commit to applicature-dlitvinov/web3-onboard that referenced this issue Jun 7, 2022
Adamj1232 pushed a commit that referenced this issue Jun 7, 2022
* [fix] fix connect wallet with disableModal flag
* fix(#1032): update package version
@Adamj1232
Copy link
Member

This has been merged into staging for testing and should be released shortly!

@Adamj1232
Copy link
Member

Released in latest version of core/react package, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants