Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-v2.2.11-alpha.2 , react-v2.1.8-alpha.2]: enhancement - update connected wallets balance #1038

Merged
merged 20 commits into from
Jun 7, 2022
Merged

[core-v2.2.11-alpha.2 , react-v2.1.8-alpha.2]: enhancement - update connected wallets balance #1038

merged 20 commits into from
Jun 7, 2022

Conversation

mahmud-bn
Copy link
Contributor

@mahmud-bn mahmud-bn commented Jun 3, 2022 •
edited
Loading

Description

Exposes updatedBalances function to allow for balance updating.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@mahmud-bn mahmud-bn changed the title [core-v2.2.11-alpha.1 , react-v2.1.8-alpha.1]: enhancement - update connected wallets balance # [core-v2.2.11-alpha.1 , react-v2.1.8-alpha.1]: enhancement - update connected wallets balance Jun 3, 2022
@mahmud-bn mahmud-bn requested a review from Adamj1232 June 6, 2022 19:52
lnbc1QWFyb24
lnbc1QWFyb24 approved these changes Jun 7, 2022
View reviewed changes
Copy link
Collaborator

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

mahmud-bn
mahmud-bn commented Jun 7, 2022
View reviewed changes
Copy link
Contributor Author

@mahmud-bn mahmud-bn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core version bump

@mahmud-bn mahmud-bn changed the title [core-v2.2.11-alpha.1 , react-v2.1.8-alpha.1]: enhancement - update connected wallets balance [core-v2.2.11-alpha.2 , react-v2.1.8-alpha.2]: enhancement - update connected wallets balance Jun 7, 2022
@mahmud-bn mahmud-bn merged commit e47459b into v2-web3-onboard-develop Jun 7, 2022
@mahmud-bn mahmud-bn deleted the enhancement/update-account-balance branch June 7, 2022 15:52
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnbc1QWFyb24 lnbc1QWFyb24 lnbc1QWFyb24 approved these changes

@taylorjdawson taylorjdawson Awaiting requested review from taylorjdawson

@Adamj1232 Adamj1232 Awaiting requested review from Adamj1232

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahmud-bn @Adamj1232 @lnbc1QWFyb24