[core-v2.3.0-alpha.1] : Feature - Transaction notifications #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmud-bn
approved these changes
Jun 16, 2022
taylorjdawson
approved these changes
Jun 17, 2022
| @@ -3,7 +3,7 @@ | |||
| "version": "2.0.2", | |||
| "private": true, | |||
| "workspaces": [ | |||
| "./packages/*" | |||
There was a problem hiding this comment.
@Adamj1232 What did removing the ./ prefix resolve?
There was a problem hiding this comment.
@taylorjdawson Im not too sure, @aaronbarnardsound added that
packages/core/README.md
Outdated
| - `Notification.link` - add link to hash | ||
| - `Notification.onClick()` - notification body click event | ||
|
|
||
| Notify can also be completely styled by using the CSS variables found below. These are setup to allow for maximum customization with base styling variables setting to global the global more themed styling (i.e. `--onboard-grey-600`) as well as a more precise component level styling available (`--notify-onboard-grey-600`) with the latter taking precedent if defined |
There was a problem hiding this comment.
These are setup to allow for maximum customization with base styling variables setting to global the global more themed styling
@Adamj1232 this sentence is a little confusing I think 🤔
There was a problem hiding this comment.
That sentence makes 0 sense, lol thanks for pointing that out!
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Adamj1232
commented
Jun 17, 2022
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Co-authored-by: Taylor Dawson <taylorjdawson@gmail.com>
Adamj1232
commented
Jun 17, 2022
…b.com:blocknative/onboard into feature/transaction-notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the new Transaction Notification feature that will act similar to Notify V1 in that when a wallet connects through Onboard a subscription will be setup through the new MultiChain SDK to watch and notify on all transactions associated with that address.
By default, is Account Center is enabled and there is a DApp ID notifications are enabled.
When switching chains the listener will continue to watch on the previous chain for 60 seconds to capture any remaining notifications and then the subscription will close on the previous chain for all connected accounts.
Notifications can be customized through 3 routes (all visible in the demo code):
onboard.state.actions.customNotificationsmethod which returns anupdateanddismissmethod for further controlChecklist
package.jsonis incremented following semantic versioning