Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes RPC request for hd wallets #1072

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Fixes RPC request for hd wallets #1072

merged 2 commits into from
Jun 22, 2022

Conversation

taylorjdawson
Copy link
Contributor

@taylorjdawson taylorjdawson commented Jun 16, 2022 •
edited by Adamj1232
Loading

Description

  • Handles case where result is undefined or null
  • Updated demo for testing sending transactions and getting the transaction receipt

Wallets Tested

Checklist

  • The version field in package.json is incremented following semantic versioning
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@taylorjdawson
Fixes RPC request for hd wallets:
a06db96 
* Handles case where result is undefined or null
@taylorjdawson taylorjdawson changed the title Fixes RPC request for hd wallets: Fixes RPC request for hd wallets Jun 16, 2022
@taylorjdawson
Copy link
Contributor Author

Thanks for the reviews/testing gents 🙌🏾 @Adamj1232 @aaronbarnardsound

@taylorjdawson taylorjdawson merged commit 4f55840 into v2-web3-onboard-develop Jun 22, 2022
@taylorjdawson taylorjdawson deleted the fix/hd-wallets-rpc-request-errors branch June 22, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnbc1QWFyb24 lnbc1QWFyb24 lnbc1QWFyb24 approved these changes

@Adamj1232 Adamj1232 Awaiting requested review from Adamj1232

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taylorjdawson @lnbc1QWFyb24