Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-v2.3.1-alpha.3]: Feature - Allow defining container element for account center #1096

Conversation

moein
Copy link
Contributor

@moein moein commented Jun 24, 2022

Description

Introducing a new config under AccountCenter to allow defining the element to where the account center is appended to.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

Fixes #1094

@Adamj1232
Copy link
Member

@moein thank you for the PR! We had a release today so if you could update the target develop branch and package version that should handle the conflicts and we can get this tested and merged! Thanks!

@Adamj1232
Copy link
Member

@moein ping on resolving conflicts for develop branch update when you have a chance

@taylorjdawson taylorjdawson requested a review from Adamj1232 July 8, 2022 14:29
Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for fixin this up @taylorjdawson 💯

@taylorjdawson taylorjdawson merged commit b2e2ec3 into blocknative:v2-web3-onboard-develop Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Allow defining the container element
4 participants