Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core: 2.4.0-alpha.2] : [fix] - Autoselect Validation #1121

Merged
merged 5 commits into from
Jul 5, 2022

Conversation

lnbc1QWFyb24
Copy link
Collaborator

Description

This fixes the validation for the object that is passed to the connectWallet function so that it does not accept and empty object which causes errors.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232
Copy link
Member

@aaronbarnardsound will we want to bump the core and internal version in all the packages that use core to capture and test these changes?

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 it!!

@lnbc1QWFyb24 lnbc1QWFyb24 merged commit e2e00a5 into v2-web3-onboard-develop Jul 5, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 deleted the fix/autoselect-validation branch July 5, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants