Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-v2.4.0-alpha.6, react-v2.2.3-alpha.4, vue v2.1.3-alpha.4] : Update - Refactor updateBalance within notification trigger #1129

Merged
merged 3 commits into from
Jul 7, 2022
Merged

[core-v2.4.0-alpha.6, react-v2.2.3-alpha.4, vue v2.1.3-alpha.4] : Update - Refactor updateBalance within notification trigger #1129

merged 3 commits into from
Jul 7, 2022

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Jul 7, 2022 •
edited
Loading

Description

Refactor flow of updateBalance on notification trigger

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 merged commit 878bd9c into v2-web3-onboard-develop Jul 7, 2022
@Adamj1232 Adamj1232 deleted the feature/updateBalance_success_notification-2 branch July 7, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylorjdawson taylorjdawson taylorjdawson approved these changes

@lnbc1QWFyb24 lnbc1QWFyb24 Awaiting requested review from lnbc1QWFyb24

@mahmud-bn mahmud-bn Awaiting requested review from mahmud-bn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adamj1232 @taylorjdawson