Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-v2.4.0-alpha.8] : Enhancement - Add --onboard-modal-color #1136

Merged

Conversation

ReflectiveChimp
Copy link
Contributor

@ReflectiveChimp ReflectiveChimp commented Jul 9, 2022

Description

Adds --onboard-modal-color (to compliment --onboard-modal-background).

Maintains the current default color initial (via all: initial on <onboard-v2/>)

Needed to change default text color for modals such as:
image

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 changed the title Add --onboard-modal-color [core-v2.4.0-alpha.8] : Enhancement - Add --onboard-modal-color Jul 11, 2022
@Adamj1232
Copy link
Member

Adamj1232 commented Jul 11, 2022

@ReflectiveChimp looks good, thank you for the PR! Could you also add the variable to this section Probably needs a new group

/* CUSTOMIZE THE SHARED MODAL */
--onboard-modal-background
--onboard-modal-color

I will get this merged today

@taylorjdawson taylorjdawson self-requested a review July 11, 2022 18:02
@Adamj1232 Adamj1232 merged commit 9735596 into blocknative:v2-web3-onboard-develop Jul 11, 2022
This was referenced Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants