Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common-v2.1.7-alpha.1, core-v2.6.0-alpha.1, react-v2.2.5-alpha.1, vue-2.1.5-alpha.1, demo-v2.0.6]: Enhancement - Convert Wei to Eth #1137

Merged
merged 15 commits into from
Jul 28, 2022
Merged

[common-v2.1.7-alpha.1, core-v2.6.0-alpha.1, react-v2.2.5-alpha.1, vue-2.1.5-alpha.1, demo-v2.0.6]: Enhancement - Convert Wei to Eth #1137

merged 15 commits into from
Jul 28, 2022

Conversation

mahmud-bn
Copy link
Contributor

@mahmud-bn mahmud-bn commented Jul 10, 2022 •
edited
Loading

Description

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

lnbc1QWFyb24
lnbc1QWFyb24 requested changes Jul 13, 2022
View reviewed changes
packages/core/src/utils.ts Outdated Show resolved Hide resolved
@mahmud-bn mahmud-bn changed the title [core-v]: Enhancement - Convert Wei to Eth [common-v2.1.7-alpha.1, core-v2.6.0-alpha.1, react-v2.2.5-alpha.1, vue-2.1.5-alpha.1, demo-v2.0.6]: Enhancement - Convert Wei to Eth Jul 15, 2022
lnbc1QWFyb24
lnbc1QWFyb24 requested changes Jul 22, 2022
View reviewed changes
packages/common/src/hdwallets.ts Outdated Show resolved Hide resolved
packages/common/src/utils.ts Outdated Show resolved Hide resolved
packages/core/src/provider.ts Outdated Show resolved Hide resolved
packages/core/src/provider.ts Outdated Show resolved Hide resolved
packages/core/src/utils.ts Outdated Show resolved Hide resolved
@mahmud-bn mahmud-bn requested a review from lnbc1QWFyb24 July 22, 2022 17:54
taylorjdawson
taylorjdawson suggested changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@taylorjdawson taylorjdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few suggestions

packages/core/src/provider.ts Outdated Show resolved Hide resolved
packages/core/src/provider.ts Outdated Show resolved Hide resolved
packages/common/src/utils.ts Show resolved Hide resolved
packages/common/src/index.ts Outdated Show resolved Hide resolved
@mahmud-bn mahmud-bn merged commit af5a09f into v2-web3-onboard-develop Jul 28, 2022
@Adamj1232 Adamj1232 mentioned this pull request Jul 28, 2022
Merged
5 tasks
@Adamj1232 Adamj1232 deleted the enhancement/weitoeth-format branch January 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnbc1QWFyb24 lnbc1QWFyb24 lnbc1QWFyb24 approved these changes

@taylorjdawson taylorjdawson taylorjdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahmud-bn @taylorjdawson @lnbc1QWFyb24