-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core-v2.4.0-alpha.8, react-v2.2.3-alpha.5, vue-v2.1.3-alpha.6] : Feature - Preflight notification handling #1138
Merged
Adamj1232
merged 17 commits into
v2-web3-onboard-develop
from
feature/preflight-notifications
Jul 11, 2022
Merged
[core-v2.4.0-alpha.8, react-v2.2.3-alpha.5, vue-v2.1.3-alpha.6] : Feature - Preflight notification handling #1138
Adamj1232
merged 17 commits into
v2-web3-onboard-develop
from
feature/preflight-notifications
Jul 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnbc1QWFyb24
requested changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments, but otherwise looks pretty good 👍
lnbc1QWFyb24
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This was referenced Jul 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Pre-flight Notification functionality to deliver standard notifications along with preflight information by passing a
PreflightNotificationOptions
object to thepreflightNotification
action. This will return a a promise that resolves to the transaction hash or nullPromise<string> | null
.Preflight event types include
txRequest
: Alert user there is a transaction request awaiting confirmation by their wallettxAwaitingApproval
: A previous transaction is awaiting confirmationtxConfirmReminder
: Reminder to confirm a transaction to continue - configurable with thetxApproveReminderTimeout
property; defaults to 15 secondsnsfFail
: The user has insufficient funds for transaction (requiresgasPrice
,estimateGas
,balance
,txDetails.value
)txError
: General transaction error (requiressendTransaction
)txSendFail
: The user rejected the transaction (requiressendTransaction
)txUnderpriced
: The gas price for the transaction is too low (requiressendTransaction
)Checklist
package.json
is incremented following semantic versioning