Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common:2.1.6-alpha.1] [keepkey:2.1.6-alpha.1] - Better Error Messages #1146

Merged
merged 6 commits into from
Jul 15, 2022

Conversation

lnbc1QWFyb24
Copy link
Collaborator

Description

This PR includes:

  • Style modifications to the rendered error message in the account select modal for hardware wallets
  • Modifies the keepkey pin entry error to render a string message
  • Formats the error returned from rpc for when the network cannot be detected

Screen Shot 2022-07-15 at 10 35 13 am

Closes #982

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to bump the Core package version of the core package import(and the core package version)?

Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped common versions in packages that use common to capture changes to the Account Select modal

@Adamj1232 Adamj1232 merged commit 59729e1 into v2-web3-onboard-develop Jul 15, 2022
@Adamj1232 Adamj1232 deleted the fix/hw-error-msgs branch July 15, 2022 14:20
This was referenced Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Keepkey doesn't properly display error when canceling operations
2 participants