Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gas:2.0.0-alpha.2] [core:2.6.0-alpha.7] - [enhancement] - Modify Gas API Response #1171

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

lnbc1QWFyb24
Copy link
Collaborator

Description

After working with the Gas API for an upcoming feature, I realised that it is more convenient if the responses came back as an array of responses rather than a mapping of chainId -> response. This PR modifies the API to do that and increments versions.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 merged commit 9b285dc into v2-web3-onboard-develop Jul 27, 2022
@Adamj1232 Adamj1232 deleted the enhancement/modify-gas-api branch July 27, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants