[core:2.7.0-alpha.4] - Dynamically import Notify and Account Center #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmud-bn
approved these changes
Aug 11, 2022
Adamj1232
reviewed
Aug 11, 2022
| {#await notifyComponent then Notify} | ||
| {#if Notify} | ||
| <svelte:component | ||
| this={Notify} |
There was a problem hiding this comment.
Sweet! I havent seen this approach before 🎸
|
@aaronbarnardsound Cool approach! I think we will want these core package changes in the React and Vue packages as well |
taylorjdawson
approved these changes
Aug 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR dynamically imports both the Account Center and Notify code. For apps that have these features disabled, this will save ~35kb of user bandwidth on the initial JS download.
Checklist
package.jsonis incremented following semantic versioningyarn type-check&yarn buildto confirm there are not any associated errors