Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-v2.2.6-alpha.2] : Enhancement - WalletState[] return to connect and disconnect hooks #1217

Merged

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Aug 16, 2022

Description

Add WalletState[] return value to connect and disconnect hooks within the React Package.
This allows for clearer insight into which wallets are connected and their states on both connect and disconnect

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

Copy link
Collaborator

@lnbc1QWFyb24 lnbc1QWFyb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Adamj1232 Adamj1232 merged commit a5ad576 into v2-web3-onboard-develop Aug 17, 2022
@Adamj1232 Adamj1232 deleted the enhancement/connect_hook_enhancement branch August 17, 2022 00:21
This was referenced Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants