Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-v2.8.1-alpha.2] : Fix - Enable customNotifications without connected wallets or API key #1232

Merged

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Aug 24, 2022

Description

This change updates the logic around enabling and displaying notifications for the purpose of using customNotifications without needing an APIkey or any connected wallets

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn type-check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 merged commit 361fa2a into v2-web3-onboard-develop Aug 24, 2022
@Adamj1232 Adamj1232 deleted the fix/enable_customNotifications_withoutAPI_ branch August 24, 2022 18:22
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants