Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[injected-v2.2.2-alpha.2] : Fix - Add functionality to MM getInterface to check provider against all other provider flags #1258

Merged

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Sep 7, 2022

Description

Add functionality to MM getInterface to check provider against all other provider flags.
This is needed in cases such as usage within Brave browser where Brave wallet has both a flag for isMetaMask and isBraveWallet
This added functionality can be added to other wallet interfaces in the case there is collision between provider flags.

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 merged commit f08b85d into v2-web3-onboard-develop Sep 9, 2022
@Adamj1232 Adamj1232 deleted the fix/metamask_provider_flag_handling branch September 9, 2022 15:22
@Adamj1232 Adamj1232 changed the title [injected-v2.2.2-alpha.1] : Fix - Add functionality to MM getInterface to check provider against all other provider flags [injected-v2.2.2-alpha.2] : Fix - Add functionality to MM getInterface to check provider against all other provider flags Sep 9, 2022
@heisenberg-2077 heisenberg-2077 mentioned this pull request Oct 20, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants