Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[injected-v2.2.2-alpha.1] : Feature - Add core wallet support, fix scroll issue #1259

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

Adamj1232
Copy link
Member

@Adamj1232 Adamj1232 commented Sep 7, 2022

Description

Adds Core(Avalanche) wallet support
Fixes a scroll issue where if a wallet was selected from the modal that had to be scrolled down to, upon selecting the Connecting..., Error... and Connected view would display outside of the modal view and would have to be scrolled to - see images below:
BEFORE:
Screen Shot 2022-09-07 at 4 49 25 PM
Screen Shot 2022-09-07 at 4 49 19 PM

AFTER:
Screen Shot 2022-09-07 at 4 50 07 PM
Screen Shot 2022-09-07 at 4 50 00 PM
Screen Shot 2022-09-07 at 5 03 08 PM (2)

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

@Adamj1232 Adamj1232 merged commit dba164e into v2-web3-onboard-develop Sep 9, 2022
@Adamj1232 Adamj1232 deleted the feature/add_core_wallet branch September 9, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants