[core-v2.8.4-alpha.1, react-v2.3.4-alpha.1, vue-v2.2.4-alpha.1]: Fix - AC UI balance & rpcUrl whitespace bug #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adamj1232
changed the title
Adamj1232
requested review from
lnbc1QWFyb24,
taylorjdawson and
gesquinca
and removed request for
lnbc1QWFyb24
taylorjdawson
approved these changes
Sep 15, 2022
| @@ -6,7 +6,6 @@ assignees: | |||
| - taylorjdawson | |||
| - aaronbarnardsound | |||
| - Adamj1232 | |||
| - mahmud-bn | |||
| @@ -5,6 +5,7 @@ labels: [feature] | |||
| assignees: | |||
| - taylorjdawson | |||
| - aaronbarnardsound | |||
| - Adamj1232 | |||
lnbc1QWFyb24
approved these changes
Sep 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix overflow within the Account Center balance where the balance runs outside of the AC container.
To do this ellipsis were used and a max container width both on max & min AC.
Also fixed a bug where is there was any trailing or beginning spaces on the rpcUrl string when adding a new network an error is thrown.
This was accomplished by trimming the whitespace on rpcUrls when setting them in W3O state upon initialization.
Error thrown prior to fix when whitespace was present:
Checklist
package.jsonis incremented following semantic versioningyarn check&yarn buildto confirm there are not any associated errors