Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphics and links on docs #1274

Merged
merged 30 commits into from
Sep 22, 2022

Conversation

gesquinca
Copy link
Contributor

Description

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • I have run yarn check & yarn build to confirm there are not any associated errors
  • This PR passes the Circle CI checks

- center wallets row on larger screens
- add correct link
- remove old faq.md
- update hero-img.svg
- remove unused HeroBackground.svelte file
- small style updates to Button and HeroSection
- add updated wallet-row graphic
- remove unused svg components
- style tweaks to theming section
- add updated wallet-row svg
- update imports
- remove unused components
@gesquinca gesquinca requested review from taylorjdawson and techgangboss and removed request for taylorjdawson September 15, 2022 22:02
@gesquinca gesquinca changed the title Feature/documentation images Update graphics and links on docs Sep 15, 2022
@gesquinca gesquinca requested a review from Adamj1232 September 16, 2022 22:38
Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small change to remove commented out code

@taylorjdawson taylorjdawson changed the base branch from feature/documentation to docs-main September 19, 2022 21:23
@taylorjdawson taylorjdawson changed the base branch from docs-main to docs-develop September 19, 2022 21:27
@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
web3-onboard-docs ✅ Ready (Inspect) Visit Preview Sep 21, 2022 at 10:43PM (UTC)

- reduce having the same info on two places
- rework admonition types.
- reduce the use of 'theming' in language. We don't really support themes. We support customizing some css properties via variables.
- remove fonts and borders section.
- update language to use css custom properties vs variables for clarity.
@gesquinca gesquinca marked this pull request as ready for review September 22, 2022 00:00
@techgangboss techgangboss merged commit f94d18c into docs-develop Sep 22, 2022
@Adamj1232 Adamj1232 deleted the feature/documentation-images branch January 26, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants