-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ledger connector with support for WalletConnect v2 #1549
feat: Ledger connector with support for WalletConnect v2 #1549
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
911c933
to
2c108d2
Compare
2c108d2
to
1f6a15c
Compare
1f6a15c
to
7a4b6b5
Compare
7a4b6b5
to
8450c52
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
8450c52
to
e43420d
Compare
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
5883656
to
3038b2a
Compare
3038b2a
to
024401a
Compare
024401a
to
20d8a18
Compare
20d8a18
to
b1a0d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of small changes requested.
I still need to test it out locally, but I wanted to ask which platforms is the Ledger Connect not available so that I can also try out the WalletConnect functionality?
Sorry for not including that on the PR description. You can test the WalletConnect support on Chrome; the Extension is currently only available on Safari iOS and macOS. |
We've released the final version of Connect Kit and I've updated the package dependency. |
4cf8f22
to
463afc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the package.json for packages/ledger to:
"version": "2.4.7-alpha.1",
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Description
We (Ledger) have a working connector which supports the Ledger browser Extension and WalletConnect v1. This PR adds support for WalletConnect v2, based on code from the WalletConnect connector and an updated Ledger Connect Kit library.
We've added new parameters to the connector
Checklist
package.json
of the package you have made changes in is incremented following semantic versioning and using alpha release taggingyarn file-check
,yarn type-check
&yarn build
to confirm there are not any associated errorsIf this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn dev
to get the project running athttp://localhost:8080/
Wasn't able to run the internal demo, tested with this custom example app, https://64905dc39ea33271d1d1a2f4--ledger-w3o-vite-demo.netlify.app/
Tests with demo app (SDK)