Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Account center updates #1740

Merged
merged 33 commits into from
May 26, 2023
Merged

Enhancement: Account center updates #1740

merged 33 commits into from
May 26, 2023

Conversation

leightkt
Copy link
Contributor

Description

Update Account Center default location, animation, and position of components.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)
Screenshot 2023-05-24 at 4 29 50 PM

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3-onboard-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 8:09pm

@leightkt leightkt self-assigned this May 24, 2023
@leightkt leightkt requested a review from Adamj1232 May 24, 2023 22:30
@leightkt leightkt changed the title Account center updates Enhancement: Account center updates May 24, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
@web3-onboard/core@2.15.5 None +0 cmeisl

packages/core/README.md Outdated Show resolved Hide resolved
@Adamj1232
Copy link
Member

The z-index animation when AC max slides in looks to be above AC min again - swapping those will clean up the animation a bit

@Adamj1232
Copy link
Member

Also getting some duplicates within the react demo when linking and changing the position of account center with the Max AC opened
Screenshot 2023-05-25 at 8 58 56 AM

leightkt and others added 2 commits May 25, 2023 13:00
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com>
Copy link
Member

@Adamj1232 Adamj1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@leightkt leightkt merged commit 3c9410b into develop May 26, 2023
@leightkt leightkt deleted the account-center-updates branch May 26, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants