-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add support for injected wallet download URL for unavailable injected wallets #1754
Conversation
…unavailable and url is available
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good- tested in the demo app and working as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work on this!
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
…hat code block destroy/creation
Description
This PR adds the ability for a download or homepage link to be defined per injected wallet and displayed if that wallet is unavailable and selected by the user.
There is also a refinement to the init option
displayUnavailable
allowing an array to also be passed (along with still supporting a boolean to display all unavailable) to more easily define which wallets to display if unavailable. This all based on passing inProviderLabel.${walletName}
to the array.This solves the problem of easily allowing dapps (often driven by partnerships with wallets) to easily choose which unavailable wallets to display.
Also, solving the issue of injected wallets creating separate modules just to get this functionality - with even less complexity for dapp devs to support the request.
There is also an update to the displayed message if a wallet is unavailable and selected and a URL is available hyperlinking the
install
text within the message displayed to the user.Example init usage (also seen in docs and README):
Resulting in:
Checklist
package.json
of the package you have made changes in following semantic versioning and using alpha release taggingyarn check-all
to confirm there are not any associated errors