Cede store new implementation #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Adamj1232
reviewed
Jul 5, 2023
Adamj1232
reviewed
Jul 5, 2023
Adamj1232
reviewed
Jul 5, 2023
Adamj1232
reviewed
Jul 5, 2023
Adamj1232
reviewed
Jul 5, 2023
|
@clementjuventin thank you for the PR! |
|
@clementjuventin friendly ping on the above notes |
clementjuventin
force-pushed
the
cede-store-new-implementation
branch
from
80fee44 to
ba8aea4
Compare
clementjuventin
force-pushed
the
cede-store-new-implementation
branch
from
ba8aea4 to
1c5598a
Compare
|
Thank you @Adamj1232 and sorry for the delay. I've taken your previous comments into account and updated the PR. |
Adamj1232
reviewed
Jul 12, 2023
Adamj1232
reviewed
Jul 12, 2023
Adamj1232
reviewed
Jul 12, 2023
Adamj1232
requested changes
Jul 12, 2023
This was referenced Jul 20, 2023
Merged
Merged
Adamj1232
added a commit
that referenced
this pull request
Jul 20, 2023
* Fix file imports for validation within WC to handle ESM envs (#1833) * Cede store new implementation (#1804) * feat: cede store new implementation * fix: version fix and changing mocked chain to the existing one * feat: cede-store-provider-upgrade-1.0.3 * fix: remove yarn.lock files * Format and yarn it * Revert deletion of yarn.lock from demo --------- Co-authored-by: Mathieu <mathieu.raimbault@hotmail.com> Co-authored-by: Nikita TEREKHOV <nikita.a.terekhov@gmail.com> Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * feat: add Fordefi wallet (#1820) * feat: add Fordefi wallet * fix: remove comma * Update packages/injected/src/types.ts --------- Co-authored-by: Adam Carpenter <adamcarpenter86@gmail.com> * Update: Return bn_protect protect btn to update the user's RPC (#1841) * Add back in btn protect btn that was accidentally removed during the AC redesign * Bump core version in docs * Cleanup onboard service in docs * Update frame icon * Bump frame version * Update global version * Remove alpha flags --------- Co-authored-by: clementjuventin <62065633+clementjuventin@users.noreply.github.com> Co-authored-by: Mathieu <mathieu.raimbault@hotmail.com> Co-authored-by: Nikita TEREKHOV <nikita.a.terekhov@gmail.com> Co-authored-by: Rony Fragin <98841690+rony-arnac@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have recently updated our provider. This change is an opportunity to update the package version and refresh the according documentation.
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (SDK)