Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add SubWallet wallet #1875

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

S2kael
Copy link
Contributor

@S2kael S2kael commented Aug 10, 2023

Description

Add SubWallet wallet into web3-onboard.

SubWallet is the comprehensive non-custodial wallet solution for Polkadot, Substrate & Ethereum ecosystems. With the mission of bringing users closer to Web3, we envision a Web3 multiverse gateway through which users can enjoy multichain services with utmost ease and absolute security. Connecting and using blockchain-based applications is smoother than ever with SubWallet Browser Extension & SubWallet Mobile App.

The provider is available on window.SubWallet.

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

  • Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
  • Check the box that allows repo maintainers to update this PR
  • Test locally to make sure this feature/fix works
  • Run yarn check-all to confirm there are not any associated errors
  • Confirm this PR passes Circle CI checks
  • Add or update relevant information in the documentation

Docs Checklist

  • Include a screenshot of any changes (see docs README on running locally)
  • Add/update the appropriate package README (if applicable)
  • Add/update the related module in the docs demo (if applicable)
  • Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/

Tests with demo app (injected)

  • send transaction
  • switch chains
  • sign message
  • sign typed message
  • disconnect

@taylorjdawson
Copy link
Contributor

@S2kael Thanks for this addition! Going to take a look at this PR and we'll get it merged 🙌

Copy link
Contributor

@taylorjdawson taylorjdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just want to bump the alpha version, but besides that it looks good 👍

packages/demo/package.json Outdated Show resolved Hide resolved
packages/injected/package.json Outdated Show resolved Hide resolved
@S2kael
Copy link
Contributor Author

S2kael commented Aug 12, 2023

We just want to bump the alpha version, but besides that it looks good 👍

Thank you, i just think my pull request can be merge at the next version so i don't change the alpha version. But I updated my version

@taylorjdawson taylorjdawson merged commit 422d220 into blocknative:develop Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants