Integration of FinoaConnect wallet connector service into Web3Onboard

[finoaamukherjee]

Description

Integration of FinoaConnect (Finoa's Wallet Connector Service) into Web3Onboard for distribution through BlockNative. For any questions or queries, please reach out to:

• Anirban Mukherjee (anirban.mukherjee@finoa.io)
• Laura Pescatori (laura.pescatori@finoa.io)

PLEASE NOTE- Checklist must be complete prior to review.

Checklist

• Increment the version field in package.json of the package you have made changes in following semantic versioning and using alpha release tagging
• Check the box that allows repo maintainers to update this PR
• Test locally to make sure this feature/fix works
• Run yarn check-all to confirm there are not any associated errors
• Confirm this PR passes Circle CI checks
• Add or update relevant information in the documentation

Docs Checklist

• Include a screenshot of any changes (see docs README on running locally)
• Add/update the appropriate package README (if applicable)
• Add/update the related module in the docs demo (if applicable)
• Add/update the related package in the docs/package.json file (if applicable)

If this PR includes changes to add an injected wallet or SDK wallet module:

Please complete the following using the internal demo package.
To run this demo use the command yarn && yarn dev to get the project running at http://localhost:8080/
[Finoa] It was verified that Finoa's documentation appears under docs. The FinoaConnect option does show up on the list of injected wallets, and we have verified that connecting and disconnecting the wallet to the dApp works fine.

Tests with demo app (injected)

• send transaction
• switch chains
• sign message
• sign typed message
• disconnect

Tests with demo app (SDK)

• send transaction
• switch chains
• sign message
• sign typed message
• disconnect

Screenshots

Screenshot of FinoaConnect under docs

[finoaamukherjee]

There are 2 topics pending on this PR on which we would appreciate some guidance:

• (Circle) CI pipeline is breaking in a job to compile core package, but the changes we have made in this PR does not include any changes to this package.
• • Could you provide some guidance on why this might be happening ?
• We have tried to include "@web3-onboard/finoaconnect:1.0.0-alpha.1" as a package in the docs but that fails in yarn checks. We are not sure why this might be happening.
• • Could you provide some guidance on how to fix this?

[Adamj1232]

There are 2 topics pending on this PR on which we would appreciate some guidance:

• (Circle) CI pipeline is breaking in a job to compile core package, but the changes we have made in this PR does not include any changes to this package.
• • Could you provide some guidance on why this might be happening ?
• We have tried to include "@web3-onboard/finoaconnect:1.0.0-alpha.1" as a package in the docs but that fails in yarn checks. We are not sure why this might be happening.
• • Could you provide some guidance on how to fix this?

Thanks for the PR - I have added a few comments and questions.

Ill checkout the CI pipeline issue.
As for testing the implementation you will use packages/demo, which will need the new module added to the package.json, initialized and added to the demo code. Then you can run yarn && yarn dev to get the demo started and complete the PR checklist.

Thanks again!

[socket-security]

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

[finoaamukherjee]

There are 2 topics pending on this PR on which we would appreciate some guidance:

• (Circle) CI pipeline is breaking in a job to compile core package, but the changes we have made in this PR does not include any changes to this package.
• • Could you provide some guidance on why this might be happening ?
• We have tried to include "@web3-onboard/finoaconnect:1.0.0-alpha.1" as a package in the docs but that fails in yarn checks. We are not sure why this might be happening.
• • Could you provide some guidance on how to fix this?

Thanks for the PR - I have added a few comments and questions.

Ill checkout the CI pipeline issue. As for testing the implementation you will use packages/demo, which will need the new module added to the package.json, initialized and added to the demo code. Then you can run yarn && yarn dev to get the demo started and complete the PR checklist.

Thanks again!

The checks for sanity are now completed in the PR, except the one for CI pipelines.
The dApp on localhost boots up fine, but does not enlist the FinoaConnect option yet. I will work to checkout why this is happening.

[finoaamukherjee]

[finoaamukherjee]

The PR has now been updated to return error code 4200 (UNSUPPORTED_METHOD) for all method calls that are not supported by FinoaConnect provider.

[Adamj1232]

@finoaamukherjee Im still seeing build errors - https://github.com/blocknative/web3-onboard/actions/runs/9503906496/job/26195385651?pr=2188

[Adamj1232]

Approved! Looks good! We really appreciate your contribution to web3-onboard 🚀