chore: update web3auth deps and fix build #2228
Conversation
|
just have one question in the code pertaining to behavior for empty rpcUrl now that web3auth does not allow undefined |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is protestware?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package my come along with functionality unrelated to its primary purpose. What is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
tested locally within our dapp |
|
@Adamj1232 ready for review! (can't add a reviewer it seems) |
|
@Adamj1232 ready for re-review, rpcUrl is required for web3auth |
|
yarn check-all passes locally @Adamj1232 one check is failing but from what I can see it originates from another merged PR |
|
@bengobeil Im getting this error running the alpha branch - does |
Yes, looks like this when I initialize it
|
from package @web3auth/ethereum-provider |
|
@bengobeil Ok well I will need to revert this merge as it doesnt look like it was tested with the internal demo app or updated for the necessary props |
|
@Adamj1232 OK, I tried using the demo app with the current version (without my changes) and it didn't seem to work either. I think there is a react dependency. I think the same props in a react app and it worked (the demo is with svelte). As for the new props, how do you want to handle that? |
|
@bengobeil new props will need to be added to the Then after checking with the internal svelte demo that it works we can test again. |
|
@Adamj1232 it seems |
|
you should get a compiler error if it's not present |
|
I will however try to get it working with the demo |
Description
resolve #2056
PLEASE NOTE- Checklist must be complete prior to review.
Checklist
package.jsonof the package you have made changes in following semantic versioning and using alpha release taggingyarn check-allto confirm there are not any associated errorsDocs Checklist
docs/package.jsonfile (if applicable)If this PR includes changes to add an injected wallet or SDK wallet module:
Please complete the following using the internal demo package.
To run this demo use the command
yarn && yarn devto get the project running athttp://localhost:8080/Tests with demo app (injected)
Tests with demo app (SDK)