Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support D'CENT wallet in PC and mobile #996

Merged
merged 8 commits into from
Jun 6, 2022
Merged

Support D'CENT wallet in PC and mobile #996

merged 8 commits into from
Jun 6, 2022

Conversation

KyungeunKim
Copy link
Contributor

@KyungeunKim KyungeunKim commented May 10, 2022 •
edited
Loading

Description

Support D'CENT wallet in PC and mobile

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

@KyungeunKim KyungeunKim changed the title V2 dev Support D'CENT wallet in PC and mobile May 10, 2022
ramsemune123
ramsemune123 reviewed May 13, 2022
View reviewed changes
Copy link

@ramsemune123 ramsemune123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#992

@ramsemune123
Copy link

#992

@Adamj1232 Adamj1232 changed the base branch from v2-web3-onboard to v2-web3-onboard-develop May 16, 2022 22:23
@Adamj1232
Copy link
Member

Adamj1232 commented May 16, 2022 •
edited
Loading

@KyungeunKim thank you for the PR! I updated the base branch to our new develop branch (v2-web3-onboard-develop) to allow for testing in the new staging env. With this if you could please merge in that develop branch to handle any conflicts and then update the version in the package.json as shown above.
It would also be helpful to add a README for the d'cent package to explain usage, initialization and any build/bundler guidance you could provide to allow for easy developer implementation

Adamj1232
Adamj1232 reviewed May 17, 2022
View reviewed changes
README.md Show resolved Hide resolved
@KyungeunKim KyungeunKim requested a review from Adamj1232 May 19, 2022 03:28
Adamj1232
Adamj1232 requested changes May 20, 2022
View reviewed changes
README.md Show resolved Hide resolved
@KyungeunKim
Copy link
Contributor Author

@Adamj1232
Thank you for your review.
I removed yarn.lock and console.log and merge v2-web3-onboard-develop branch again.

@KyungeunKim KyungeunKim requested a review from Adamj1232 May 25, 2022 08:46
Adamj1232
Adamj1232 reviewed Jun 6, 2022
View reviewed changes
packages/dcent/src/index.ts

accounts.push(account)

// console.log('generateAccounts/accounts = ', accounts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// console.log('generateAccounts/accounts = ', accounts)

@Adamj1232 Adamj1232 merged commit a61433e into blocknative:v2-web3-onboard-develop Jun 6, 2022
@lnbc1QWFyb24 lnbc1QWFyb24 mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramsemune123 ramsemune123 ramsemune123 left review comments

@Adamj1232 Adamj1232 Adamj1232 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyungeunKim @ramsemune123 @Adamj1232