Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle correctly empty transactions for Callisto #2173

Merged
merged 3 commits into from
Jun 17, 2019

Conversation

ayrat555
Copy link
Contributor

fixes

2019-06-14T07:30:01.432 fetcher=block_uncle count=10 [error] Task #PID<0.30783.673> started from Indexer.Fetcher.UncleBlock terminating
** (FunctionClauseError) no function clause matching in EthereumJSONRPC.Block.elixir_to_transactions/1
    (ethereum_jsonrpc) lib/ethereum_jsonrpc/block.ex:320: EthereumJSONRPC.Block.elixir_to_transactions(%{“difficulty” => 13003609512856, “extraData” => “0x636c6f706f6f6c2e6f7267”, “gasLimit” => 8000000, “gasUsed” => 42000, “hash” => “0xd2ae784fa5f1dcb21336282292b027e273bf7f85e123f0020819a193a2b40a4e”, “logsBloom” => “0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000”, “miner” => “0x5f7661e493d4f1a318c02e9383568597e8a09b5a”, “mixHash” => “0xa84341e505a8ea30480c464c4bc269227ac627c206b368dc0ba55308f793c6b2”, “nonce” => “0x0acbc0a002595676”, “number” => 1589332, “parentHash” => “0xbda1afe0c1458bdd76d5ce59401272a82eed761bb29a617919751f0d0ccfb402", “receiptsRoot” => “0xd95b673818fa493deec414e01e610d97ee287c9421c8eff4102b1647c1a184e4", “sha3Uncles” => “0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347", “size” => 530, “stateRoot” => “0xa24c57b061ba52e393316cc6ad8bced2ef1121ac05305d710df8df1e65e5e7d2”, “timestamp” => #DateTime<2018-12-08 10:10:36Z>, “totalDifficulty” => nil, “transactionsRoot” => “0x6365118787b0ff42b627a24c5ff2c4f8f3966e485106a5fe09c704cc3ee1ccd0”, “uncles” => []})

Changelog

  • handle correctly empty transactions

@coveralls
Copy link

coveralls commented Jun 14, 2019

Pull Request Test Coverage Report for Build 05e6b352-ee77-4019-8638-6db2d532e5ed

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.715%

Totals Coverage Status
Change from base Build 416fef69-f318-4769-a605-211baa53afeb: 0.0%
Covered Lines: 4922
Relevant Lines: 6098

💛 - Coveralls

@vbaranov vbaranov merged commit 619bc14 into master Jun 17, 2019
@vbaranov vbaranov deleted the ab-empty-transactions branch June 17, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants