Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save contract code from genesis file #2875

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

ayrat555
Copy link
Contributor

resolves #2860

Changelog

  • save contract from genesis file

@coveralls
Copy link

coveralls commented Nov 26, 2019

Pull Request Test Coverage Report for Build 63278633-df22-4e1b-92d3-0fa24e60d0ce

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 75.368%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/explorer/lib/explorer/chain_spec/genesis_data.ex 0 1 0.0%
Totals Coverage Status
Change from base Build e863a70a-68e2-421e-bc60-82d9e44c5ec4: 0.007%
Covered Lines: 5425
Relevant Lines: 7198

💛 - Coveralls

Copy link
Member

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayrat555 if I already imported spec file with the current version of the application (before these changes) and then again want to import it in order to get contract codes will not this procedure contaminate DB with duplicate coin balances or some other kinds of contamination?

@vbaranov vbaranov self-requested a review February 6, 2020 11:59
@vbaranov vbaranov force-pushed the ab-sabe-contract-code-from-genesis-file branch from c142beb to 5cc2bee Compare February 6, 2020 13:41
@vbaranov vbaranov force-pushed the ab-sabe-contract-code-from-genesis-file branch from 5cc2bee to bda7ea0 Compare February 6, 2020 13:51
@vbaranov vbaranov merged commit 92e7a4a into master Feb 6, 2020
@vbaranov vbaranov deleted the ab-sabe-contract-code-from-genesis-file branch February 6, 2020 14:00
vbaranov added a commit that referenced this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contracts deployed on genesis file not have "code" tab
3 participants