Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts read/write: method_id instead function_name as a key #3257

Merged
merged 5 commits into from
Aug 28, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Aug 26, 2020

Motivation

https://blockscout.com/poa/sokol/address/0xD99dFe5F3253CDACd1C4eCe0Da524187fD9EacF4/contracts

Screenshot 2020-08-26 at 12 31 30

Screenshot 2020-08-26 at 12 31 16

Changelog

Add method id as key in the list of contract methods instead of function name

Checklist for your Pull Request (PR)

@vbaranov vbaranov marked this pull request as draft August 26, 2020 09:32
@vbaranov vbaranov force-pushed the vb-contracts_read_method_id branch 2 times, most recently from 1acbf1d to 6260052 Compare August 26, 2020 11:04
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6260052447415ef1b3d23b168159645dfa286d80-PR-3257

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-20.01%) to 53.526%

Totals Coverage Status
Change from base Build 61f43bf111711d6c557e52c66867611962f2cb44: -20.01%
Covered Lines: 425
Relevant Lines: 794

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-contracts_read_method_id branch 4 times, most recently from 64bbd15 to b6b6627 Compare August 27, 2020 13:47
@vbaranov vbaranov marked this pull request as ready for review August 27, 2020 13:53
@vbaranov vbaranov merged commit 338a1f2 into master Aug 28, 2020
@vbaranov vbaranov deleted the vb-contracts_read_method_id branch August 28, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant