Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokens list pagination #3350

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Fix tokens list pagination #3350

merged 1 commit into from
Oct 13, 2020

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Oct 13, 2020

Motivation

  • Some tokens are missing on the 2nd page of bridged tokens list
  • Numeration of the items starts with 1 on every page (tokens list, bridged tokens list, addresses list)

Changelog

  • Fix pagination query filtering by ordered token name
  • Add items count on the previous pages in the query for the next page to account it in numeration

Checklist for your Pull Request (PR)

@coveralls
Copy link

coveralls commented Oct 13, 2020

Pull Request Test Coverage Report for Build ff4eddc41306051fea59cafcd9f16b9adaa59817-PR-3350

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+3.6%) to 74.215%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
lib/block_scout_web/controllers/address_controller.ex 5 84.38%
lib/block_scout_web/controllers/tokens/bridged_tokens_controller.ex 6 0%
lib/block_scout_web/controllers/tokens/tokens_controller.ex 6 0%
lib/block_scout_web/chain.ex 8 83.05%
Totals Coverage Status
Change from base Build fbd96a2350197e804d9c877a785eecf1015c96c7: 3.6%
Covered Lines: 1986
Relevant Lines: 2676

💛 - Coveralls

@vbaranov vbaranov merged commit ce8b444 into master Oct 13, 2020
@vbaranov vbaranov deleted the vb-fix-tokens-pagination branch October 13, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants