Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sushiswap LP tokens custom metadata fetcher: bytes(n) symbol and name support #3742

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

vbaranov
Copy link
Member

@vbaranov vbaranov commented Mar 25, 2021

Motivation

Missing token name and symbol of MKR in Sushiswap LP token

Screenshot 2021-03-25 at 17 17 01

Changelog

MKR token and symbol getters have byte32 type, unlike others. This PR enables support in metadata fetcher for Sushiswap LP tokens which have bytes(n) type for symbol and token getters in token contract.

Checklist for your Pull Request (PR)

@vbaranov vbaranov changed the title Fix sushiswap lp tokens custom metadata fetcher Fix sushiswap lp tokens custom metadata fetcher: bytes(n) symbol and name support Mar 25, 2021
@vbaranov vbaranov changed the title Fix sushiswap lp tokens custom metadata fetcher: bytes(n) symbol and name support Fix Sushiswap LP tokens custom metadata fetcher: bytes(n) symbol and name support Mar 25, 2021
@vbaranov vbaranov force-pushed the vb-fix-sushiswap-custom-metadata-process branch from dc73652 to ba00eb4 Compare March 25, 2021 14:21
@coveralls
Copy link

coveralls commented Mar 25, 2021

Pull Request Test Coverage Report for Build 300b7b3866e818e09afbf11ec4b2bbec28be24c4-PR-3742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 64.63%

Files with Coverage Reduction New Missed Lines %
lib/block_scout_web/controllers/chain/market_history_chart_controller.ex 2 71.43%
Totals Coverage Status
Change from base Build 645e3efc56a80e48cfe10536db0dbb4b218296db: -0.3%
Covered Lines: 2105
Relevant Lines: 3257

💛 - Coveralls

@vbaranov vbaranov force-pushed the vb-fix-sushiswap-custom-metadata-process branch from ba00eb4 to 300b7b3 Compare March 25, 2021 14:53
@vbaranov vbaranov merged commit 668eefc into master Mar 25, 2021
@vbaranov vbaranov deleted the vb-fix-sushiswap-custom-metadata-process branch March 25, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants