Add parse input errors view; fix empty method_id #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitosing
force-pushed
the
np-contract-improvements-1
branch
from
a3254e0
to
0ace076
Compare
vbaranov
reviewed
Dec 27, 2021
| @@ -296,42 +296,11 @@ defmodule Explorer.SmartContract.Reader do | |||
| end | |||
|
|
|||
| defp get_abi_with_method_id(abi) do | |||
There was a problem hiding this comment.
@nikitosing could you elaborate on the refactoring of this function?
vbaranov
approved these changes
Dec 28, 2021
nikitosing
force-pushed
the
np-contract-improvements-1
branch
from
0ace076
to
13c1977
Compare
nikitosing
force-pushed
the
np-contract-improvements-1
branch
from
13c1977
to
0d902eb
Compare
sidhujag
pushed a commit
to syscoin/blockscout
that referenced
this pull request
Dec 28, 2021
…ements-1 Add parse input errors view; fix empty method_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4874
Changelog
Enhancements
Add view for parse errors (appears in cases when input ABI type is
tuple[])Bug Fixes
tuple[]but actual type more complexChecklist for your Pull Request (PR)
CHANGELOG.mdwith this PRmasterin the Version column. Changes will be reflected in this table: https://docs.blockscout.com/for-developers/information-and-settings/env-variables.