Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rollup features #1599

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Refactor rollup features #1599

merged 3 commits into from
Feb 12, 2024

Conversation

tom2drum
Copy link
Collaborator

@tom2drum tom2drum commented Feb 12, 2024

Description and Related Issue(s)

Resolves #1595

Proposed Changes

  • NEXT_PUBLIC_IS_OPTIMISTIC_L2_NETWORK and NEXT_PUBLIC_IS_ZKEVM_L2_NETWORK replaced by NEXT_PUBLIC_ROLLUP_TYPE
  • NEXT_PUBLIC_OPTIMISTIC_L2_WITHDRAWAL_URL renamed to NEXT_PUBLIC_ROLLUP_L2_WITHDRAWAL_URL
  • NEXT_PUBLIC_L1_BASE_URL renamed to NEXT_PUBLIC_ROLLUP_L1_BASE_URL

Breaking or Incompatible Changes

  • all l2<something> components and types are renamed to optimisticL2<something>
  • L2 views for optimistic and zkEvm are grouped by their route names (e.g, deposits/optimisticL2/**)
  • optimisticRollup and zkEvmRollup features are combined into rollup

Additional Information

  • added file with list of deprecated ENVs

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@tom2drum tom2drum force-pushed the tom2drum/issue-1595 branch from 4a73997 to 740adc8 Compare February 12, 2024 08:22
@tom2drum tom2drum requested a review from isstuev February 12, 2024 08:38
@tom2drum tom2drum merged commit df35285 into main Feb 12, 2024
@tom2drum tom2drum deleted the tom2drum/issue-1595 branch February 12, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor rollup features
2 participants