Try @helia/verified-fetch for fetching NFT images from IPFS
#2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom2drum
added
the
skip checks
tom2drum
force-pushed
the
tom2drum/issue-2356
branch
from
96484f2 to
94f8add
Compare
tom2drum
force-pushed
the
tom2drum/issue-2356
branch
from
4e4a5bd to
d3d0c1a
Compare
tom2drum
added
ENVs
and removed
skip checks
tom2drum
commented
Nov 8, 2024
There was a problem hiding this comment.
I believe these screenshots are correct because the last two rows of the images are not in the viewport. We lazy load them once they come into view.
tom2drum
commented
Nov 8, 2024
Comment on lines
+121
to
+123
| <TabPanel padding={ 0 } key={ tab.id?.toString() || (typeof tab.title === 'string' ? tab.title : undefined) }> | ||
| { tab.component } | ||
| </TabPanel> |
There was a problem hiding this comment.
This fixes one of the warnings on the Token instance page.
tom2drum
commented
Nov 8, 2024
| @@ -39,7 +39,7 @@ const MetadataItemPrimitive = ({ name, value, isItem = true, isFlat, level }: Pr | |||
| })(); | |||
|
|
|||
| return ( | |||
| <Component level={ level } isFlat={ isFlat }> | |||
| <Component level={ level } { ...(isItem ? { isFlat } : {}) }> | |||
There was a problem hiding this comment.
And this fixes another warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
Resolves #2356
Added
NEXT_PUBLIC_HELIA_VERIFIED_FETCH_ENABLEDto enable Helia verified fetch for retrieving content of NFT assets directly from IPFS network using trustless gateways.Checklist for PR author