Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos Update CONTRIBUTING.md #2377

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Typos Update CONTRIBUTING.md #2377

merged 1 commit into from
Nov 11, 2024

Conversation

0xwitty
Copy link
Contributor

@0xwitty 0xwitty commented Nov 9, 2024

Typos and grammatical inconsistencies correction.

Description and Related Issue(s)

  1. "your need" — This phrase appears twice, but it should be "you need" for proper grammar.

    • Original: "Include only secrets your need."
    • Corrected: "Include only secrets you need."
  2. "If your changes only related" — This sentence is missing the verb "are."

    • Original: "If your changes only related to the logic of the app..."
    • Corrected: "If your changes are only related to the logic of the app..."
  3. "in all test for React components" — It should be "tests" (plural).

    • Original: "please do not import package @testing-library/react directly in your test suites, instead use imports from jest/lib utility."
    • Corrected: "please do not import the package @testing-library/react directly in your test suites, instead use imports from jest/lib utility."

Corrected.

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable
    • I updated the list of environment variables in the documentation
    • I made the necessary changes to the validator script according to the guide
    • I added "ENVs" label to this pull request

Typos and grammatical inconsistencies correction.
@tom2drum tom2drum merged commit 8da3472 into blockscout:main Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants