fix: missing optional argument from decryptMnemonic function #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
force-pushed
the
fix/mnemonic-decryption
branch
from
284cb57 to
d05344d
Compare
|
I think the legacy "triplesec" handling needs adjusted for this, per unit test failure |
kyranjamie
force-pushed
the
fix/mnemonic-decryption
branch
2 times, most recently
from
9e1224d to
4c795a8
Compare
zone117x
reviewed
Jun 22, 2020
kyranjamie
force-pushed
the
fix/mnemonic-decryption
branch
4 times, most recently
from
bdef802 to
2e3a128
Compare
kyranjamie
force-pushed
the
fix/mnemonic-decryption
branch
from
2e3a128 to
3aaf773
Compare
kyranjamie
changed the title
zone117x
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
?to decrypt mnemonic function.See 3aaf773 for non-formatting changes