Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: persist keys on disk #157

Merged
merged 6 commits into from
Jul 6, 2020
Merged

feat: persist keys on disk #157

merged 6 commits into from
Jul 6, 2020

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Jun 22, 2020 •
edited
Loading

This PR adds:

  • Test runner/CI job
  • Encryption of a users mnemonic phrase on disk
  • Decryption/rederivation of a user's private key

@kyranjamie kyranjamie self-assigned this Jun 22, 2020
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 3 times, most recently from 67a4ee5 to ab02077 Compare June 22, 2020 14:34
aulneau
aulneau reviewed Jun 22, 2020
View reviewed changes
app/pages/home/home.tsx Outdated Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 5 times, most recently from 12c1d8b to 70a3d42 Compare June 23, 2020 08:37
@kyranjamie kyranjamie linked an issue Jun 23, 2020 that may be closed by this pull request
Encrypt private key on disk #145
Closed
3 tasks
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 11 times, most recently from a309a1d to a655886 Compare June 23, 2020 13:00
@kyranjamie kyranjamie marked this pull request as ready for review June 23, 2020 13:05
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 2 times, most recently from 74a53b9 to b7906ae Compare June 23, 2020 13:22
kyranjamie
kyranjamie commented Jun 23, 2020
View reviewed changes
app/store/keys/keys.actions.ts Outdated

// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
const [error, mnemonic] = await safeAwait(decryptMnemonic(encryptedMnemonic, key));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting on PR from blockstack.js

@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch from b7906ae to b27a3b4 Compare June 23, 2020 15:25
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 7 times, most recently from d44fbec to 8bfb3c3 Compare June 28, 2020 16:19
@kyranjamie kyranjamie force-pushed the release/stacking branch 2 times, most recently from 9901c2c to 1e14ba5 Compare June 29, 2020 11:19
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 3 times, most recently from 20a73db to 1d672b7 Compare June 30, 2020 13:14
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 2 times, most recently from 371be8e to cba7d28 Compare June 30, 2020 13:30
hstove
hstove approved these changes Jul 2, 2020
View reviewed changes
app/api/get-balance.ts Outdated Show resolved Hide resolved
app/components/transaction-list/transaction-list-item.tsx Show resolved Hide resolved
app/store/keys/keys.reducer.ts Show resolved Hide resolved
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch 5 times, most recently from ef8f60b to 4f4749b Compare July 3, 2020 12:30
@kyranjamie kyranjamie force-pushed the feat/persist-private-key branch from 4f4749b to 71d016b Compare July 5, 2020 17:20
@kyranjamie
Copy link
Collaborator Author

Merging with broken build. A minor advisory on the lodash package is pending a fix.

@kyranjamie kyranjamie merged commit b21c026 into release/stacking Jul 6, 2020
@kyranjamie kyranjamie deleted the feat/persist-private-key branch July 6, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstove hstove hstove approved these changes

@aulneau aulneau Awaiting requested review from aulneau

@zone117x zone117x Awaiting requested review from zone117x

Assignees

@kyranjamie kyranjamie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encrypt private key on disk
3 participants
@kyranjamie @hstove @aulneau