forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3385 #102
Draft
zebullax
wants to merge
28
commits into
bloomberg:p2996
Choose a base branch
from
zebullax:p3385
base: p2996
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
P3385 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually parse the reflection on assume
Stash early ith attributes of
Stash attributesOf
…commit on Stash interim splice Stash interim splice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implementation effort for attributes reflection as described in P3385R2
Describe your changes
Support attributes reflection
^^[[nodiscard]];
std::meta::has_identifier(r)
std::meta::is_attribute(r)
std::meta::identifier_of(r)
std::meta::attributes_of(r)
[[ [: r :] ]]
r
reflecting a std attribute, a typedata_member_options_t{ .attributes { ...
Testing performed
Smoke test is described here
Additional context
⚠️ I will leave it as a draft for as long as it doesn't reach meaningful quality of implementation.
This is a work in progress && for awareness purpose mostly